Review of "Eruption Profile Switcher" version 21

Details Page Preview

Runtime Profile switcher for the Eruption Realtime RGB LED Driver for Linux

Extension Homepage
https://github.com/eruption-project/eruption-profile-switcher

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
Timeouts in line 426 and 447 (extension.js) should be removed on disable. Also you hold the timeout id but not removing it in disable (line 406, 1212 and 1232 extenion.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources