Review of "Eruption Profile Switcher" version 36

Details Page Preview

Runtime Profile switcher for the Eruption Realtime RGB LED Driver for Linux

Extension Homepage
https://github.com/eruption-project/eruption-profile-switcher

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Please remove the version from import since that has been specified in the parent module (line 22-23 prefs.js). 2. No need to use `this.initTranslation()`: > Consider this method deprecated. > Only specify gettext-domain in metadata.json. > GNOME Shell can automatically initiate the translation for you > when it sees the gettext-domain key in metadata.json. https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils 3. Just pass the settings from the entry point instead of creating it again (line 62 and 106 prefs.js). 4. You don't need to use the schema id for `this.getSettings()` when it is specified in the `metadata.json`: https://gjs.guide/extensions/overview/anatomy.html#settings-schema