Review "Eruption Profile Switcher" version 22

Review of "Eruption Profile Switcher" version 22

Details Page Preview

Eruption Profile Switcher

by X3n0m0rph59

Runtime Profile switcher for the Eruption Realtime RGB LED Driver for Linux

Extension Homepage: https://github.com/eruption-project/eruption-profile-switcher

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
38	Active
37	Rejected
36	Rejected
35	Rejected
34	Rejected
33	Active
32	Active
31	Active
30	Active
29	Rejected
28	Rejected
27	Active
26	Active
25	Active
24	Active
23	Rejected
22	Rejected
21	Rejected
20	Active
19	Inactive
18	Active
17	Rejected
16	Rejected
15	Active
14	Active
13	Active
12	Active
11	Rejected
10	Active
9	Active
8	Rejected
7	Active
6	Rejected
5	Active
4	Rejected
3	Active
2	Active
1	Active

Previous Reviews on this Version

JustPerfection rejected March 19, 2022

You should remove all of those timeouts in `disable()` just like line 1497 - 1498. Because we don't want the callbacks get triggered after disable. For example inside unlock dialog. Even timeouts with 0ms as duration can get delayed.