Please move line 17 (extension.js ) to enable(): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization

It's forked from the official extension user-theme. You know I would prefer to put it in the global scope myself. https://gitlab.gnome.org/GNOME/gnome-shell-extensions/-/blob/main/extensions/user-theme/extension.js#L17

Thanks for the report. The original extension got updated (both enable and disable): https://gitlab.gnome.org/GNOME/gnome-shell-extensions/-/blob/762ec75601362dec7b117953f1af954de21f9c59/extensions/user-theme/extension.js#L17

Congrats, you'll want to look into other official extensions. There should be more opportunities to improve compatibility with the review guide, like this: https://gitlab.gnome.org/GNOME/gnome-shell-extensions/-/blob/762ec75601362dec7b117953f1af954de21f9c59/extensions/auto-move-windows/extension.js#L12 Also, no need to use optional chaining operator (?.) for the function in `disable()`. If you insist, `this._settings.run_dispose?.()` will be a better choice: https://gitlab.gnome.org/GNOME/gnome-shell-extensions/-/blob/762ec75601362dec7b117953f1af954de21f9c59/extensions/user-theme/extension.js#L23 By the way, the `run_dispose()` method seems not to be recommended to be called outside it's "object system implementations": https://gjs-docs.gnome.org/gobject20~2.66p/gobject.object#method-run_dispose In terms of a more detailed explanation, avoiding low-level memory management functions like `run_dispose` will be a better than better option for you: https://stackoverflow.com/a/61404218

WindowMover instance is created on enable (not init): https://gitlab.gnome.org/GNOME/gnome-shell-extensions/-/blob/762ec75601362dec7b117953f1af954de21f9c59/extensions/auto-move-windows/extension.js#L144 and getting destroyed on disable: https://gitlab.gnome.org/GNOME/gnome-shell-extensions/-/blob/762ec75601362dec7b117953f1af954de21f9c59/extensions/auto-move-windows/extension.js#L150 So it is compatible with the review guidelines.

Good to know that, I just randomly looked at the first 12 lines and not the rest of the code. Sorry, I should have said might be instead of should be.