Review of "User Theme X" version 36

Details Page Preview

Customizable user-theme with user stylesheet and dark theme auto-switch based on the Night Light For support, please report any issues via the homepage link below.

Extension Homepage
https://github.com/tuberry/user-theme-x

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Please remove version from the import (line 7 `util.js`). 2. Also we have the same issue for `run_dispose()` here just like the other extension: [Extension List Review: Version 39](https://extensions.gnome.org/review/54079)
grroot posted a review
1. Just add it to avoid the following warning in the prefs page, I'm ok to remove it if it messes with gnome-shell or other extensions. `JS WARNING: [resource:///org/gnome/gjs/modules/esm/gi.js 16]: Requiring Soup but it has 2 versions available; use imports.gi.versions to pick one`
JustPerfection posted a review
GNOME Shell 46 is using version 3. anyway, that was a recommendation not a reason to reject but what's the distro?
grroot posted a review
It's Arch, maybe it's because the prefs run in a separate process and there is package that depends on libsoup2?
JustPerfection posted a review
Yes, the prefs process is different. anyway, if there is a distro shipping two versions of soup, versions should be there.