Review of "gNordVPN-Local" version 7

Details Page Preview

A Gnome extension that shows the NordVPN status in the top bar and provides the ability to configure certain aspects of the connection.

Extension Homepage
https://github.com/Isopolito/gNordVPN-Local

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
29 Active
28 Active
27 Active
26 Active
25 Active
24 Rejected
23 Active
22 Rejected
21 Active
20 Active
19 Rejected
18 Rejected
17 Rejected
16 Active
15 Active
14 Rejected
13 Active
12 Rejected
11 Active
10 Active
9 Active
8 Active
7 Rejected
6 Active
5 Active
4 Active
3 Rejected
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. You cannot create objects in global scope which is the same as init. line 12-14 (extension.js), line 8-11 (modules/CountryMenu.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. Also do this on disable: _vpnIndicator = null; 3. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions