Review of "gNordVPN-Local" version 24

Details Page Preview

A Gnome extension that shows the NordVPN status in the top bar and provides the ability to configure certain aspects of the connection.

Extension Homepage
https://github.com/Isopolito/gNordVPN-Local

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
29 Active
28 Active
27 Active
26 Active
25 Active
24 Rejected
23 Active
22 Rejected
21 Active
20 Active
19 Rejected
18 Rejected
17 Rejected
16 Active
15 Active
14 Rejected
13 Active
12 Rejected
11 Active
10 Active
9 Active
8 Active
7 Rejected
6 Active
5 Active
4 Active
3 Rejected
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. Please don't use deprecated modules (line 58 `modules/Vpn.js`): [EGO Review Guidelines: deprecated modules](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#do-not-use-deprecated-modules) 2. `lookupByURL()` is a bad practice. You can send `this` from the entry point to the class needing it when it's possible (dependency injection). - line 5 `modules/Favorites.js` - line 8 `modules/PanelIcon.js` - line 25 `modules/VpnIndicator.js`
Isopolito posted a review
Thanks JustPerfection for the feedback, making these fixes now. Once local testing is complete I'll resubmit