Review of "gNordVPN-Local" version 14

Details Page Preview

A Gnome extension that shows the NordVPN status in the top bar and provides the ability to configure certain aspects of the connection.

Extension Homepage
https://github.com/Isopolito/gNordVPN-Local

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
29 Active
28 Active
27 Active
26 Active
25 Active
24 Rejected
23 Active
22 Rejected
21 Active
20 Active
19 Rejected
18 Rejected
17 Rejected
16 Active
15 Active
14 Rejected
13 Active
12 Rejected
11 Active
10 Active
9 Active
8 Active
7 Rejected
6 Active
5 Active
4 Active
3 Rejected
2 Active
1 Active

Previous Reviews on this Version

JustPerfection waiting for author
Ok but `Soup` has been loaded in GNOME Shell before and trying to change the version isn't doing anything (line 7 modules/Vpn.js).
Isopolito posted a review
That line has been in there for a while. The issue is that there were breaking changes between soup 2 and 3 and certain distros (Fedora off the top of my head) were using soup 3.x by default in gnome 42. This was breaking the extension in that distro. Forcing the version to 2.x fixed it. The version of this extension for gnome 43 does not have that compatibility force in it. I'm on element extensions channel right now if you want to talk in real time
Isopolito posted a review
That line has been in there for a while. The issue is that there were breaking changes between soup 2 and 3 and certain distros (Fedora off the top of my head) were using soup 3.x by default in gnome 42. This was breaking the extension in that distro. Forcing the version to 2.x fixed it. The version of this extension for gnome 43 does not have that compatibility force in it. I'm on element extensions channel right now if you want to talk in real time
JustPerfection rejected
Please remove that line and create a function that can check the soup version. Thanks!