Review of "gNordVPN-Local" version 22

Details Page Preview

A Gnome extension that shows the NordVPN status in the top bar and provides the ability to configure certain aspects of the connection.

Extension Homepage
https://github.com/Isopolito/gNordVPN-Local

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
29 Active
28 Active
27 Active
26 Active
25 Active
24 Rejected
23 Active
22 Rejected
21 Active
20 Active
19 Rejected
18 Rejected
17 Rejected
16 Active
15 Active
14 Rejected
13 Active
12 Rejected
11 Active
10 Active
9 Active
8 Active
7 Rejected
6 Active
5 Active
4 Active
3 Rejected
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. You cannot create instances in global scope which is the same as init (line 11-14 prefs.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. Make them local not global because they won't get garbage collected after disable (line 15 prefs.js).
Isopolito posted a review
Yeah good call I forgot about that, the way that extensions are monkey patched into the gnome shell means that global variables would pollute the whole shell. I'll fix and resubmit