Review of "ArcMenu" version 26

Details Page Preview

Application menu for GNOME Shell Features include: various menu layouts, built in GNOME search, quick access to system shortcuts, and much more! Common solutions for ERROR message: - Restart your GNOME session after updating ArcMenu. - Install one of the following packages: 'gir1.2-gmenu-3.0' or 'gnome-menus' General Help: - Visit https://gitlab.com/arcmenu/ArcMenu/-/wikis/home Please report all bugs or issues at https://gitlab.com/arcmenu/ArcMenu

Extension Homepage
https://gitlab.com/arcmenu/ArcMenu

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
63 (63) Active
62 (62) Active
61 (61) Active
60 (60) Active
59 (59) Active
58 (58) Active
57 (57) Active
56 (56) Active
55 (55) Active
54 (54) Active
53 (53) Active
52 Active
51 Active
50 Rejected
49 Active
48 Active
47 Active
46 Active
45 Active
44 Active
43 Active
42 Active
41 Active
40 Rejected
39 Active
38 Active
37 Active
32 Active
31 Active
30 Active
29 Active
28 Active
27 Active
26 Rejected
16 Active
13 Active
10 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Inactive

Previous Reviews on this Version

andrew_z posted a review
recentFilesManager is being used in the extension (GNOME shell) not the settings. Is this fix a viable approach?
JustPerfection rejected
_settings and _recentManager still will remain there after `disable()`. That's the point of not having it as global. You have two options: - Do the same approach but also create a helper function in `recentFilesManager.js` to clean that up in disable: in recentFilesManager.js: ```js function cleanup() { _recentManager = null; _settings = null; } ``` Now you can call `recentFilesManager.cleanup()` in disable. - Pass those objects as dependency injection (in your case function parameter).
andrew_z posted a review
Can you take a look at https://gitlab.com/arcmenu/ArcMenu/-/commit/154e1fe4abc0f134700496aafcfe74ed6e459146 ? I changed the recentFilesManager to a class and now calling a new destroy() call when needed.
JustPerfection posted a review
LGTM.