Review "OpenWeather" version 107 - GNOME Shell Extensions

Review of "OpenWeather" version 107

Details Page Preview

OpenWeather

by skrewball

Display weather information for any location on Earth in the GNOME Shell

Extension Homepage: https://gitlab.com/skrewball/openweather

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
121	Active
120	Rejected
119	Active
118	Active
117	Active
116	Active
115	Active
114	Active
113	Active
112	Rejected
111	Active
110	Active
109	Active
108	Rejected
107	Active
106	Active
105	Active
104	Rejected
103	Rejected
102	Active
101	Rejected
100	Active
99	Active
98	Rejected
97	Active
96	Active
95	Active
94	Active
93	Rejected
92	Active
91	Active
90	Active
89	Active
88	Active
87	Active
86	Active
85	Active
84	Active
83	Active
82	Rejected
81	Active
80	Active
79	Active
78	Active
77	Active
76	Active
75	Active
74	Active
73	Active
72	Rejected
71	Active
70	Active
69	Rejected
68	Rejected
67	Active
66	Active
65	Active
64	Active
63	Active
62	Active
61	Active
60	Active
59	Active
58	Active
57	Active
56	Rejected
55	Active
54	Active
53	Active
52	Active
51	Active
50	Active
49	Rejected
48	Active
47	Active
46	Active
45	Rejected
44	Rejected
43	Rejected
42	Active
41	Active
40	Active
39	Active
38	Active
37	Active
36	Active
35	Active
34	Rejected
33	Active
32	Active
31	Active
30	Active
29	Active
28	Active
27	Active
26	Active
25	Active
24	Active
23	Active
22	Rejected
21	Rejected
20	Active
19	Rejected
18	Rejected
17	Active
16	Active
15	Active
14	Rejected
13	Active
12	Rejected
11	Rejected
10	Rejected
9	Active
8	Rejected
7	Rejected
6	Rejected
5	Rejected
4	Rejected
3	Rejected
2	Rejected
1	Rejected

Previous Reviews on this Version

skrewball posted a review April 18, 2022

The next version will remove the legacy Lang class as well as darksky as they are ending their API by the end of the year.

JustPerfection waiting for author April 18, 2022

1. Why do you use version for Soup? (line 47 extension.js)? It's getting imported in GNOME Shell before you do that: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/ui/environment.js#L31-41 2. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 3. Null out `openweatherMenu` in `disable()`. 4. What is the use case for those timeouts in prefs.js? If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions

skrewball posted a review April 18, 2022

I was getting an error with Soup after forking the repo: "Requiring Soup but it has 2 versions available; use imports.gi.versions to pick one". Requiring the specific version fixed the location search issue. It looks like the timeouts were put there by the previous dev to prevent it from continuously updating on refresh. Removing Lang is next on my to-do list. I assume I need to upload a new version to add the null in disable()? Thanks!

JustPerfection active April 18, 2022

Prefs code needs some clean up for sure and yes, you need to upload a new version for that. Please fix it for the next version.

JustPerfection posted a review April 18, 2022

btw, remove `localedir` from `metadata.json`.

skrewball posted a review April 18, 2022

Honestly, quite a bit of the code needs some cleaning up lol. Would adding the null to disable and removing the localedir in metadata.json be ok to get a new version approved for users? Then fixing prefs and removing lang in the version after that.

JustPerfection posted a review April 18, 2022

Yes! You can send the next one with those two fixes.

skrewball posted a review April 18, 2022

I just noticed this version was active haha, so I'll do more cleanup before submitting the next version. Thanks again! :)