Review of "Alsa Mixer" version 4

Details Page Preview

Control Alsa master volume from status menu. Requires 'amixer', provided by alsa-utils package.

Extension Homepage
https://github.com/tghosgor/gnome-shell-extension-alsamixer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

fmuellner waiting for author
Overall looks OK, just a few suggestions to consider: - you should avoid sync IO in the compositor whenever possible - remember that the user's entire desktop will freeze while the call is blocking (reading the output obviously gets trickier, but change to async at least when you don't) - adding the indicator after the arrow is broken - you can do better by doing something along the lines of statusMenu.insert_child_above(indicatorIcon, statusMenu._volume.indicators); - ugh, pgrep pulseaudio? You should do better, not least to have your extension working when pulseaudio is terminated after it has been enabled; did you consider something like: statusMenu._volume.indicators.connect('notify::visible', function(a) { indicatorIcon.visible = item.actor.visible = !a.visible; });
tghosgor posted a review
statusMenu.insert_child_above(indicatorIcon, statusMenu._volume.indicators); <-- THIS! I have been looking for this thank you. :) I am new to gnome-shell extensions and your review helped a lot. I will do the suggested changes when I can.
tghosgor rejected
New version using async calls for "amixer set". Removed pulse check. Now depending on gnome-shell to hide volume indicator if pulse isn't up. Default volume sliders are hidden based on volume indicator visibility.