Review of "Alsa Mixer" version 14

Details Page Preview

Control Alsa master volume from status menu. Requires 'amixer', provided by alsa-utils package.

Extension Homepage
https://github.com/tghosgor/gnome-shell-extension-alsamixer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

tghosgor posted a review
Date: Sun Jun 8 18:39:56 2014 +0300 changed variable namings again. fd leak in amixerReadCb. corrected Mainloop.timeout_add_seconds usage.
fmuellner active
Thanks! Regarding variable names: - all the stream variables (amixerStdoutId, outReaderId, dataStdoutId) still use the 'id' convention for normal objects (e.g. *no* IDs) - using volumeVisibleId to store the handler ID for the 'notify::visible' signal was perfectly fine, you should consider keeping that Not a reason to reject the extension of course ...