Review of "Alsa Mixer" version 10

Details Page Preview

Control Alsa master volume from status menu. Requires 'amixer', provided by alsa-utils package.

Extension Homepage
https://github.com/tghosgor/gnome-shell-extension-alsamixer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

tghosgor posted a review
fixed not disconnecting volume indicator signal. fixed not clearing timeout source
fmuellner active
For what it's worth, we use fooId as convention for all source identifiers in gnome-shell - so "volumeVisibilitySignal" and "interval" would be something like "volumeVisibleId" and "timeoutId". Obviously it is fine to *not* follow that convention if you don't want to. I still think you should hide your menu when pulseaudio is active (not just the indicator), but that's not a reason to reject the extension - approved at last!
tghosgor posted a review
I will rename accordingly in the future releases if I have time. Thanks.