Review of "Alsa Mixer" version 9

Details Page Preview

Control Alsa master volume from status menu. Requires 'amixer', provided by alsa-utils package.

Extension Homepage
https://github.com/tghosgor/gnome-shell-extension-alsamixer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

tghosgor posted a review
Added async synchronization with current alsa volume level. Volume changes are posted async. Volume sliders are hidden if default volume indicator is hidden. Volume sliders are shown if default volume indicator is shown. Extension volume indicator is hidden if default volume indicator is visible. Extension volume indicator is shown if default volume indicator is hidden.
fmuellner rejected
You need to disconnect the signal you connect in enable(). You should also hide your menu item to avoid showing two volume sliders in the pulseaudio case (probably easiest to add a separate function for that and call it both outside and inside the signal handler). (Also the readVolume() function is a bit sloppy as you assume that you only need a single read to get at the data you want - still, I guess that's OK with the buffer size you're setting) Rejecting due to the lingering signal connection, which will result in warnings after disabling the extension.
tghosgor posted a review
How can I do async single-reads on a file?
fmuellner posted a review
I'm not aware of any method to do that - the usual approach is to read repeatedly until EOF is reached (as you already do in the newer version)