Review of "Bring Out Submenu Of Power Off Button" version 44

Details Page Preview

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Please remove the timeouts on destroy: - line 21 and 40 SyncLabel.js - line 14 extension.js https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 2. Where do you remove the label widget from the layout manager on disable (line 11 LabelLauncher.js)? https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects 3. Remove line 20-21 from `BringoutMenu.js` and use this instead: ```js _init(settings) { this._settings = settings; // ... } ``` Now, in line 10 (`extension.js`) use this instead: ```js modifiedMenu = new BringoutMenu(this._settings); ```