Review of "Bring Out Submenu Of Power Off Button" version 45

Details Page Preview

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Remove the timeouts in the same class you are creating it. Inside `SyncLabel` create a `destroy()` method and remove those timeouts here. You should also call `SyncLabel.destroy()` for each instance in `BringoutMenu._destroy()`. 2. Move line 33 (extension.js) to the end of disable. Because those objects using that and you should null that out after you destroy those objects. 3. #2 from version 44 review hasn't been addressed here.
PRATAP PANABAKA posted a review
Hi @JustPerfection, point no 3 above, "#2 from version 44 review has not been addressed here." You mean I did not do anything about it. I tried it in this way. BringoutMenu.js line 106 actionButtons = this._actionItems.get_children(); line 107 actionButtons.forEach(button => { if (button.accessible_name) { const callSync = new SyncLabel(button); // stack St label widget from Line 12 of LabelLauncher.js to remove in _destroy() this._labelLaunchers.push(callSync._toolTip.label); button._handlerId = button.connect('notify::hover', () => { callSync._syncLabel(); }); } }); } line 121 _destroy() { // refer to line 108 above this._labelLaunchers.forEach(launcher => { if (launcher) { Main.layoutManager.removeChrome(launcher); launcher.destroy(); launcher = null; } line 129 }); I think I cant progress it further without experts help, can you have some time for me to guide on these points via a video call or support me in gnome discourse please?
JustPerfection posted a review
To fix that, create `LabelLauncher.destroy()` and then do this in `destroy()`: ```js Main.layoutManager.removeChrome(this.label); this.label = null; ```
JustPerfection posted a review
btw, you can always ask questions in GNOME Extensions Matrix Channel: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions