Review of "GLocalSend" version 4

Details Page Preview

A LocalSend client integrated into the GNOME Quick Settings Files, text and clipboard data can be sent to nearby devices upon the user's request using the appropriate buttons in each device's dropdown menu.

Extension Homepage
https://github.com/donnybeelo/gnome-extensions-glocalsend

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO025 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO014 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:101
            this._descriptionLabel = new St.Label({
                style_class: "prompt-dialog-description",
                x_align: Clutter.ActorAlign.START,
                y_align: Clutter.ActorAlign.START,
            })
  • extension.js:106
            this._entry = new St.Entry({
                hint_text: "Type text to send",
                x_expand: true,
            })
  • extension.js:110
            this._errorLabel = new St.Label({
                style_class: "prompt-dialog-error",
                x_align: Clutter.ActorAlign.START,
                y_align: Clutter.ActorAlign.START,
            })
  • extension.js:96
            this._titleLabel = new St.Label({
                style_class: "prompt-dialog-title",
                x_align: Clutter.ActorAlign.START,
                y_align: Clutter.ActorAlign.START,
            })
  • extension.js:202
            this._filesLabel = new St.Label({
                style_class: "prompt-dialog-description",
                x_align: Clutter.ActorAlign.START,
                y_align: Clutter.ActorAlign.START,
            })
  • extension.js:197
            this._summaryLabel = new St.Label({
                style_class: "prompt-dialog-title",
                x_align: Clutter.ActorAlign.START,
                y_align: Clutter.ActorAlign.START,
            })

EGO027 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:101
            this._descriptionLabel = new St.Label({
                style_class: "prompt-dialog-description",
                x_align: Clutter.ActorAlign.START,
                y_align: Clutter.ActorAlign.START,
            })
  • extension.js:106
            this._entry = new St.Entry({
                hint_text: "Type text to send",
                x_expand: true,
            })
  • extension.js:110
            this._errorLabel = new St.Label({
                style_class: "prompt-dialog-error",
                x_align: Clutter.ActorAlign.START,
                y_align: Clutter.ActorAlign.START,
            })
  • extension.js:96
            this._titleLabel = new St.Label({
                style_class: "prompt-dialog-title",
                x_align: Clutter.ActorAlign.START,
                y_align: Clutter.ActorAlign.START,
            })
  • extension.js:202
            this._filesLabel = new St.Label({
                style_class: "prompt-dialog-description",
                x_align: Clutter.ActorAlign.START,
                y_align: Clutter.ActorAlign.START,
            })
  • extension.js:197
            this._summaryLabel = new St.Label({
                style_class: "prompt-dialog-title",
                x_align: Clutter.ActorAlign.START,
                y_align: Clutter.ActorAlign.START,
            })

All Versions

Version Status
9 Unreviewed
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Daniel Elia auto- rejected
Auto-rejected because of new version 5 was uploaded