Review of "GLocalSend" version 11

Details Page Preview

A LocalSend client integrated into the GNOME Quick Settings Files, text and clipboard data can be sent to nearby devices upon the user's request using the appropriate buttons in each device's dropdown menu.

Extension Homepage
https://github.com/donnybeelo/gnome-extensions-glocalsend

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:220
    St.Clipboard.get_default()
  • extension.js:503
    St.Clipboard.get_default()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:122
            this._entry.clutter_text.connect("activate", () => {
                this._submit();
            })

All Versions

Version Status
14 Active
13 Active
12 Active
11 Active
10 Rejected
9 Rejected
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection active
JustPerfection posted a review
This comment that you have in the description isn't really needed: > Uses Main.panel.statusArea.quickSettings to add the indicator (private API; required for Quick Settings integration).