Review of "GLocalSend" version 10

Details Page Preview

A LocalSend client integrated into the GNOME Quick Settings Files, text and clipboard data can be sent to nearby devices upon the user's request using the appropriate buttons in each device's dropdown menu.

Extension Homepage
https://github.com/donnybeelo/gnome-extensions-glocalsend

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) manual_review 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:223
    St.Clipboard.get_default()
  • extension.js:491
    St.Clipboard.get_default()

All Versions

Version Status
14 Active
13 Active
12 Active
11 Active
10 Rejected
9 Rejected
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please add empty lines between functions and classes. Since the source is TypeScript, you can use prettier for that. 2. Don't need to use any parameters for `this.getSettings()` since you already have that in `metadata.json`. 3. `this._enabled` and `this._destroyed` is a bad practice. Please remove that. 4. Selective disable isn't allowed (line 160-161 `extension.js`). 5. Please remove line 2 `common.js`. Not needed. 6. Better not do that since you already have `this.path` in the entry point (line 15 `extension.js`). You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions