Review of "GLocalSend" version 8

Details Page Preview

A LocalSend client integrated into the GNOME Quick Settings Files, text and clipboard data can be sent to nearby devices upon the user's request using the appropriate buttons in each device's dropdown menu.

Extension Homepage
https://github.com/donnybeelo/gnome-extensions-glocalsend

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3 manual_review 1

Shexli found 4 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:443
    St.Clipboard.get_default()

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 6 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • localsend.js:288
    console.warn(`LocalSend prepare-upload failed: ${messageText}`)
  • localsend.js:347
    console.warn(`LocalSend could not enable UDP port sharing: ${message}`)
  • localsend.js:387
    console.warn(`LocalSend discovery packet failed: ${message}`)
  • localsend.js:424
    console.warn(`LocalSend register response failed for ${peer.alias}: ${message}`)
  • localsend.js:444
    console.warn(`LocalSend multicast response failed: ${message}`)
  • localsend.js:739
    console.warn(`LocalSend port ${preferredPort} is already in use; falling back to an ephemeral port.`)

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:91
            this._content = new St.BoxLayout({
                vertical: true,
                x_expand: true,
                y_expand: true,
                style_class: "prompt-dialog-content",
            })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:91
            this._content = new St.BoxLayout({
                vertical: true,
                x_expand: true,
                y_expand: true,
                style_class: "prompt-dialog-content",
            })

All Versions

Version Status
9 Unreviewed
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Daniel Elia auto- rejected
Auto-rejected because of new version 9 was uploaded