Review of "GLocalSend" version 17

Details Page Preview

A LocalSend client integrated into the GNOME Quick Settings Files, text and clipboard data can be sent to nearby devices upon the user's request using the appropriate buttons in each device's dropdown menu.

Extension Homepage
https://github.com/donnybeelo/gnome-extensions-glocalsend

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:263
    St.Clipboard.get_default()
  • extension.js:328
    St.Clipboard.get_default()
  • extension.js:632
    St.Clipboard.get_default()

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['46', '47', '48', '49', '50', '51']

All Versions

Version Status
18 Active
17 Rejected
16 Rejected
15 Active
14 Active
13 Active
12 Active
11 Active
10 Rejected
9 Rejected
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
You still can't do that. If your extension depends on that spawn command, you should create an app and make it as a dependency of this extension. They can communicate between each other via d-bus: https://gjs.guide/guides/gio/dbus.html