Review "Dash2Dock Animated" version 92

Review of "Dash2Dock Animated" version 92

Details Page Preview

Dash2Dock Animated

by icedman

The Animated & Effectful Dock

Extension Homepage: https://github.com/icedman/dash2dock-lite

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 4

Shexli found 5 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 6 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

animator.js:116
```
console.log('unable to layout()')
```
animator.js:1084
```
console.log(err)
```
animator.js:1112
```
console.log(err)
```
animator.js:1139
```
console.log(err)
```
animator.js:1170
```
console.log(err)
```
animator.js:1183
```
console.log(err)
```
services.js:404
```
console.log(`checking ${path}`)
```
services.js:530
```
console.log('checking recent manager')
```
services.js:542
```
console.log(err)
```
services.js:561
```
console.log('not exists')
```
services.js:578
```
console.log(err)
```
services.js:617
```
console.log(err)
```

EGO-C49-004 error

extensions targeting GNOME 49 must not call Meta.Window.get_maximized

This extension explicitly targets GNOME Shell 49 but still calls removed `Meta.Window.get_maximized()`.

Meta.Window

dock.js:1405
```
focusedWindow.get_maximized()
```

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 9 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

extension.js:236
```
console.log('dash2dock-lite enabled')
```
extension.js:282
```
console.log('dash2dock-lite disabled')
```
extension.js:359
```
console.log(err)
```

extension.js:399

console.log(`loading icon ${file.get_path()}`)

extension.js:413

console.log(`loading icon ${file.get_path()}`)

extension.js:420
```
console.log(err)
```
extension.js:458
```
console.log(err)
```
extension.js:477
```
console.log(err)
```
extension.js:930
```
console.log(err)
```

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

apps/overlay.js
apps/recents.js
effects/blur_effect.js
effects/color_effect.js

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

prefs.js:226

this._monitorsConfig = new MonitorsConfig()

All Versions

Version	Status
92	Active
91	Active
90	Inactive
89	Rejected
88	Rejected
87	Rejected
86	Active
85	Inactive
84	Rejected
83	Active
82	Active
81	Active
80	Active
79	Rejected
78	Active
77	Active
76	Active
75	Active
74	Active
73	Active
72	Active
71	Active
70	Active
69	Active
68	Active
67	Rejected
66	Active
65	Active
64	Active
63	Inactive
62	Rejected
61	Rejected
60	Rejected
59	Rejected
58	Rejected
57	Active
56	Rejected
55	Rejected
54	Active
53	Rejected
52	Rejected
51	Rejected
50	Rejected
49	Active
48	Rejected
47	Rejected
46	Inactive
45	Active
44	Active
43	Inactive
42	Inactive
41	Rejected
40	Rejected
39	Rejected
38	Active
37	Active
36	Inactive
35	Active
34	Active
33	Rejected
32	Active
31	Rejected
30	Active
29	Rejected
28	Active
27	Active
26	Inactive
25	Inactive
24	Active
23	Active
22	Inactive
21	Inactive
20	Active
19	Active
18	Rejected
17	Active
16	Active
15	Rejected
14	Active
13	Rejected
12	Active
11	Active
10	Rejected
9	Active
8	Active
7	Inactive
6	Inactive
5	Inactive
4	Active
3	Active
2	Rejected
1	Rejected

Previous Reviews on this Version

JustPerfection waiting for author May 26, 2026

Still using try-catch wrappers for just changing property values. Couldn't find a fix for that?

icedman posted a review May 26, 2026

I removed several of the try-catch, osme users report crashes. I had to out them back.

JustPerfection active May 26, 2026

Approved but it should be fixed at some point without these try-catch wrappers.