Review of "Dash2Dock Animated" version 91

Details Page Preview

The Animated & Effectful Dock

Extension Homepage
https://github.com/icedman/dash2dock-lite

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 6

Shexli found 7 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 11 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:134
    console.log('recreate all docks')
  • extension.js:236
    console.log('dash2dock-lite enabled')
  • extension.js:282
    console.log('dash2dock-lite disabled')
  • extension.js:359
    console.log(err)
  • extension.js:399
    console.log(`loading icon ${file.get_path()}`)
  • extension.js:413
    console.log(`loading icon ${file.get_path()}`)
  • extension.js:420
    console.log(err)
  • extension.js:458
    console.log(err)
  • extension.js:477
    console.log(err)
  • extension.js:927
    console.log(err)

EGO-I-002 error

Gtk, Gdk and Adw must not be imported in shell process files

GTK library `Gdk` must not be imported in extension process files.

Do not import GTK libraries in GNOME Shell

  • preferences/prefKeys.js:4
    import Gdk from 'gi://Gdk';

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • services.js:551
    fn.load_contents(null)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 6 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • services.js:404
    console.log(`checking ${path}`)
  • services.js:530
    console.log('checking recent manager')
  • services.js:542
    console.log(err)
  • services.js:561
    console.log('not exists')
  • services.js:578
    console.log(err)
  • services.js:617
    console.log(err)

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • apps/overlay.js
  • apps/recents.js
  • effects/blur_effect.js
  • effects/color_effect.js

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:677
    this._appSystem = Shell.AppSystem.get_default()
  • extension.js:462
    this._settings = this.getSettings(schemaId)

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:222
    this._monitorsConfig = new MonitorsConfig()

All Versions

Previous Reviews on this Version

fmuellner active