Review of "Gnome 4x, 5x UI Improvements" version 26

Details Page Preview

Tunes gnome 4x, 5x Overview UI to make it more usable. Changes: - Search textbox is hidden by default and shown only when user begins to type-to-search - Scale of workspaces' thumbnails increased 2x - Restores wallpaper on workspaces' thumbnails. No more gray background - Show workspaces' thumbnails even when there is only one workspace - Firefox's PIP (picture in picture) window is now displayed on the overview screen All modifications can be disabled in the extension's settings. ATTENTION! After extension update, gnome-shell restart is required: X11: Alt+F2 => r Wayland: logout => login

Extension Homepage
https://github.com/axxapy/gnome-ui-tune

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:40
    this.settings = this.getSettings()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:43
                this.settings.connect('changed::' + name, () => {
                    this._refresh_mod(name)
                })

All Versions

Previous Reviews on this Version

JustPerfection active
Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup.