EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

• schemas/gschemas.compiled

  schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

• extension.js:443

  this.applicationsButton = new ApplicationsMenuButton(this.getSettings())

• extension.js:80

          this.actor = new St.Bin({ style_class: 'toggle-switch',
                                    accessible_role: Atk.Role.CHECK_BOX,
                                    can_focus: true })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

• extension.js:443

  this.applicationsButton = new ApplicationsMenuButton(this.getSettings())

• extension.js:80

          this.actor = new St.Bin({ style_class: 'toggle-switch',
                                    accessible_role: Atk.Role.CHECK_BOX,
                                    can_focus: true })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• extension.js:108

          this.actor.connect('button-release-event',
                  this._onButtonReleaseEvent.bind(this))

• extension.js:111

  this.actor.connect('key-focus-in', this._onKeyFocusIn.bind(this))

• extension.js:112

  this.actor.connect('key-focus-out', this._onKeyFocusOut.bind(this))

• extension.js:110

  this.actor.connect('key-press-event', this._onKeyPressEvent.bind(this))

• extension.js:277

          this._clickGesture.connect('recognize', () => {
              if (this._clickGesture.get_button() == Clutter.BUTTON_SECONDARY) {
                  this._showDialog();
              } else {
                  this.menu?.toggle();
              }
          })

• extension.js:286

          Main.layoutManager.connect('startup-complete',
                                       this._setKeybinding.bind(this))

EGO-C45-001 warning

45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget

45+ preferences code should use `fillPreferencesWindow()` instead of `getPreferencesWidget()`.

Preferences

• prefs.js:47

      getPreferencesWidget() {
          return new ApplicationsMenuSettingsWidget(this.getSettings());
      }