Review of "Light Dict" version 56

Details Page Preview

Lightweight extension for on-the-fly manipulation to primary selections, especially optimized for Dictionary lookups For support, please report any issues via the homepage link below.

Extension Homepage
https://github.com/tuberry/light-dict

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

andyholmes active
In your two uses of Gio.Subprocess.communicate_utf8_async, you will want to wrap the "finish" call in a try..catch: ``` new Promise((resolve, reject) => { SomeObject.method_async(args, (srcObj, result) => { try { // these finish-type methods always have the chance of throwing errors const ret = srcObj.method_finish(result); // you can always still resolve/reject for other reasons ret ? resolve('success') : reject(Error('failure')); } catch (e) { reject(e); } }); }); ``` I'd also recommend you implement methods on *your* DBus interface instead of using GNOME Shell's `Eval()`. That function is not guaranteed to be available, and is kind of sketchy anyways. I know you're always working on this extension so I'll approve as-is, but please fix those in your next release :)
grroot posted a review
Thanks! I will fix those soon. :)