Review of "Light Dict" version 74

Details Page Preview

Lightweight extension for on-the-fly manipulation to primary selections, especially optimized for Dictionary lookups For support, please report any issues via the homepage link below.

Extension Homepage
https://github.com/tuberry/light-dict

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection waiting for author
The `LDOCRPY` in line 18 `prefs.js`. Should it still be there? I see that is getting used for `execute()`.
grroot posted a review
> The `LDOCRPY` in line 18 `prefs.js`. Should it still be there? I see that is getting used for `execute()`. It's used to detect the existence of `ldocr.py`(line 538) and `execute()` if exists (line 585) so that if the file does not exist, the code will not be executed.
JustPerfection active
I understand. I mean when the package doesn't have that, it shouldn't be there in the first place. Approved this one. Please remove those lines for the next version. Thanks!
grroot posted a review
> I understand. I mean when the package doesn't have that, it shouldn't be there in the first place. This path is where the script is expected to be installed, and I think a fixed path is a bit more reliable than running an executable under the user's PATH. The code is kept for the convenience of those users who need this functionality and install the file themselves. For other users, these lines are almost zero cost.
JustPerfection posted a review
It's ok. You can also add the dependency to the description.