Review of "Light Dict" version 75

Details Page Preview

Lightweight extension for on-the-fly manipulation to primary selections, especially optimized for Dictionary lookups For support, please report any issues via the homepage link below.

Extension Homepage
https://github.com/tuberry/light-dict

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
The default class constructor you are exporting is the same as global scope (line 812-825 `extension.js`).
JustPerfection posted a review
- [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects)
grroot posted a review
How about adding `gset = null;` after that?
JustPerfection posted a review
`gset` is local there, so it's not useful in this case. Anyway, you are using `this.getSettings()` in the `ExtensionBase.enable()`. basically, we don't want extensions doing anything (or too much) before enable. That's why we have the **Only use initialization for static resources** as an EGO rule. Spawn commanding and getting gsettings is definitely too much for the constructor.