Review of "Light Dict" version 68

Details Page Preview

Lightweight extension for on-the-fly manipulation to primary selections, especially optimized for Dictionary lookups For support, please report any issues via the homepage link below.

Extension Homepage
https://github.com/tuberry/light-dict

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection active
You should create `gsettings` in `fillPreferencesWindow` instead of creating it in global scope (prefs.js line 9). In that case, it can be attached to the `window` so it get destroyed when the window is getting destroyed. Another method is to destroy it in `close-request`: ```js win.connect('close-request', () => { gsettings = null; }); ```