Review "Lock screen background" version 21

Review of "Lock screen background" version 21

Details Page Preview

Lock screen background

by sun_wang

Change lock screen background.

Extension Homepage: https://github.com/sunwxg/gnome-shell-extension-unlockDialogBackground

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
35	Active
34	Active
33	Rejected
32	Rejected
31	Inactive
30	Rejected
29	Rejected
28	Active
27	Inactive
26	Inactive
25	Inactive
24	Inactive
23	Active
22	Rejected
21	Rejected
20	Active
19	Inactive
18	Active
17	Inactive
16	Inactive
15	Inactive
14	Active
13	Inactive
12	Inactive
11	Active
10	Inactive
9	Inactive
8	Inactive
7	Active
6	Inactive
5	Inactive
4	Rejected
3	Rejected
2	Inactive
1	Rejected

Previous Reviews on this Version

xiaoguang_wang auto- active September 24, 2021

JustPerfection rejected September 24, 2021

1. Move everything from init to enable: https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#Only_use_.60init.28.29.60_for_initialization 2. Destroy all objects and disconnect all signals you have created on disable(): https://wiki.gnome.org/Projects/GnomeShell/Extensions/Review#Destroy_all_objects 3. Since you are modifying lock screen you can check whether it is in lock mode, if not, disable. If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions