Review of "Lock screen background" version 42

Details Page Preview

Change lock screen background.

Extension Homepage
https://github.com/sunwxg/gnome-shell-extension-unlockDialogBackground

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • backgroundNew.js:413
    this._interfaceSettings = new Gio.Settings({schema_id: INTERFACE_SCHEMA})
  • backgroundNew.js:729
    this._interfaceSettings = new Gio.Settings({schema_id: INTERFACE_SCHEMA})
  • backgroundNew.js:721
    this._settings = new Gio.Settings({settings_schema: schemaObj})

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['51']

All Versions

Previous Reviews on this Version

JustPerfection active