Review "Lock screen background" version 41

Review of "Lock screen background" version 41

by sun_wang

Change lock screen background.

Extension Homepage: https://github.com/sunwxg/gnome-shell-extension-unlockDialogBackground

No comments.

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli found 4 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

backgroundNew.js:413

this._interfaceSettings = new Gio.Settings({schema_id: INTERFACE_SCHEMA})

backgroundNew.js:729

this._interfaceSettings = new Gio.Settings({schema_id: INTERFACE_SCHEMA})

backgroundNew.js:721

this._settings = new Gio.Settings({settings_schema: schemaObj})

extension.js:157

this.background = new DialogBackground(this.getSettings())

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

EGO-C45-001 warning

45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget

45+ preferences code should use `fillPreferencesWindow()` instead of `getPreferencesWidget()`.

prefs.js:193

    getPreferencesWidget() {
        let widget = new PrefsWidget(this.getSettings());
        return widget.widget;
    }

JustPerfection rejected September 21, 2026

Please fix those warnings mentioned by shexli.