Review "Lock screen background" version 29

Review of "Lock screen background" version 29

Details Page Preview

Lock screen background

by sun_wang

Change lock screen background.

Extension Homepage: https://github.com/sunwxg/gnome-shell-extension-unlockDialogBackground

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
35	Active
34	Active
33	Rejected
32	Rejected
31	Inactive
30	Rejected
29	Rejected
28	Active
27	Inactive
26	Inactive
25	Inactive
24	Inactive
23	Active
22	Rejected
21	Rejected
20	Active
19	Inactive
18	Active
17	Inactive
16	Inactive
15	Inactive
14	Active
13	Inactive
12	Inactive
11	Active
10	Inactive
9	Inactive
8	Inactive
7	Active
6	Inactive
5	Inactive
4	Rejected
3	Rejected
2	Inactive
1	Rejected

Previous Reviews on this Version

JustPerfection rejected September 4, 2023

1. It would be better to also remove `idle_add` signals on disable (line 89, 104, 225, 255, 458, 744 backgroundNew.js). 2. Remove timeout on disable (line 363 backgroundNew.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 3. Please remove the signal on disable (line 144 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals 4. Since your extension only uses unlock dialog, you can only use `unlock-dialog` in `session-modes`: https://gjs.guide/extensions/topics/session-modes.html