GNOME Shell Extensions

Review of "Syncthing Icon" version 30

Details Page Preview

Syncthing Icon

by jaystrict

Display Syncthing Icon in Top Bar

Extension Homepage
https://github.com/jaystrictor/gnome-shell-extension-syncthing
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
35 Active
34 Active
33 Active
32 Active
31 Rejected
30 Rejected
29 Active
28 Active
27 Active
26 Active
25 Inactive
24 Active
23 Active
22 Rejected
21 Active
20 Inactive
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. You cannot create objects in init() function. move line 267-269 (extension.js) to enable(): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 3. Use initTranslations() and getSettings() from ExtensionUtils instead of creating your own custom functions (remove convenience.js after that): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions