Review of "Coverflow Alt-Tab" version 51

Details Page Preview

Replacement of Alt-Tab, iterates through windows in a cover-flow manner.

Extension Homepage
https://github.com/dsheeler/CoverflowAltTab

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection active
Ok but it's much better to remove it on switcher destroy and then call the destroy in manager (on disable).
dsheeler posted a review
Well, I don't think that would work because destroy calls _destroy which calls _onPreviewDestroyComplete which creates the source. The timeout is a bit of a hack because If we don't do the timeout and just call the function, we get this message: Timelines with detached actors are not supported. <unnamed>[<Preview>:0x55bac6f03b30] in animation of duration 434ms but not on stage. If I remove_all_tweens on all the previews and then call the function, there's no error message and everything seems to work as expected. I'm going to test it some more, but if I don't see anything wrong, I might commit this solution.
dsheeler posted a review
Oh, and thank you for the quick reviews; I really appreciate that!
JustPerfection posted a review
Well, you should remove the timeout in `_onDestroy` of the same object. If you see the item is getting destroyed before `_onDestroy`, that means you need to fix something. I see you are destroying the object inside the same object in multiple methods. Maybe that's the reason.