Review of "Coverflow Alt-Tab" version 57

Details Page Preview

Replacement of Alt-Tab, iterates through windows in a cover-flow manner.

Extension Homepage
https://github.com/dsheeler/CoverflowAltTab

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection active
Thanks!
dsheeler posted a review
Thank you! I tried the dependency injection approach as you suggested here: ```js class Prefs { constructor(settings) { this._settings = settings; } doSomething() { // use `this._settings` here } fillWindow(window) { // to avoid garbage collecting before close this._window._prefsSettings = this._settings; // ... } } I couldn't get it to work, though. I used this._settings in my event handlers, and when they'd run, the program would crash with an error saying 'this' is null. Maybe I should have attached the pref object to window?
JustPerfection posted a review
`this._window` doesn't exist in that code. Use `window` instead of `this._window`.
dsheeler posted a review
That wasn't the problem, I was using `window` not this_window. The problem was that the prefs object doesn't exist when the event handlers run, so `this` is null