Review "Coverflow Alt-Tab" version 66 - GNOME Shell Extensions

Review of "Coverflow Alt-Tab" version 66

Details Page Preview

Coverflow Alt-Tab

by dsheeler

Replacement of Alt-Tab, iterates through windows in a cover-flow manner.

Extension Homepage: https://github.com/dsheeler/CoverflowAltTab

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
76	Active
75	Inactive
74	Rejected
73	Inactive
72	Active
71	Active
70	Active
69	Active
68	Active
67	Rejected
66	Rejected
65	Active
64	Inactive
63	Inactive
62	Inactive
61	Active
60	Active
59	Active
58	Active
57	Active
56	Rejected
55	Active
54	Active
53	Active
52	Active
51	Active
50	Rejected
49	Active
48	Active
47	Active
46	Active
45	Active
44	Active
43	Rejected
42	Active
41	Active
40	Active
39	Rejected
38	Active
37	Active
36	Active
35	Rejected
34	Rejected
33	Active
32	Active
31	Active
30	Active
29	Active
28	Active
27	Rejected
26	Active
25	Active
24	Active
23	Rejected
22	Active
21	Active
20	Active
19	Active
18	Active
17	Active
16	Active
15	Active
14	Active
13	Active
12	Active
11	Active
10	Rejected
9	Rejected
8	Active
7	Active
6	Inactive
5	Inactive
4	Rejected
3	Inactive
2	Inactive
1	Rejected

Previous Reviews on this Version

JustPerfection rejected October 25, 2023

1. `Extension.lookupByUUID()` is a bad practice. You should use `this.getSettings()` in the entry point and pass it to the class instances (dependency injection). 2. No reason to create custom `getSettings()` function, when you have `this.getSettings()` in the entry point (line 97 platform.js). 3. Don't use `var`. Use `let` and `const` instead. Use `export class` when you want to export class. 4. No need to use `this.initTranslation()` (133 prefs.js): > Consider this method deprecated. > Only specify gettext-domain in metadata.json. > GNOME Shell can automatically initiate the translation for you > when it sees the gettext-domain key in metadata.json. https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils 5. Use `GLib.timeout_add_...` instead of `Mainloop`. 6. You made the destroy process hard to review (line 1058 switcher.js). and just for that I cannot tell the timeout (line 106 and 947) always get removed on destroy.