GNOME Shell Extensions

Review of "Dash to Dock" version 72

Details Page Preview

Dash to Dock

by michele_g

A dock for the Gnome Shell. This extension moves the dash out of the overview transforming it in a dock for an easier launching of applications and a faster switching between windows and desktops. Side and bottom placement options are available.

Extension Homepage
https://micheleg.github.io/dash-to-dock/
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
92 Active
91 Active
90 Rejected
89 Active
88 Rejected
87 Active
86 Rejected
85 Rejected
84 Active
83 Active
82 Active
81 Active
80 Active
79 Active
78 Active
77 Active
76 Rejected
75 Active
74 Active
73 Active
72 Rejected
71 Active
70 Active
69 Active
68 Active
67 Active
66 Active
65 Active
64 Active
63 Active
62 Active
61 Active
60 Active
59 Active
58 Rejected
57 Active
56 Active
55 Active
54 Active
53 Active
52 Active
51 Active
50 Active
49 Active
48 Active
47 Active
46 Active
45 Active
44 Active
43 Active
42 Active
41 Active
40 Active
39 Active
38 Active
37 Active
36 Active
35 Active
34 Active
33 Active
32 Rejected
31 Rejected
30 Active
29 Active
28 Active
27 Active
26 Rejected
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Inactive
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Rejected
7 Active
6 Active
5 Rejected
4 Active
3 Active
2 Rejected
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. You should remove these timeouts in destroy: - line 470 dash.js - line 1034 locations.js - line 573 utils.js 2. The timeouts you are using in the prefs.js should be removed. extension.js side should be able to fix those issues. For example, if panel transition is an issue, you should remove the transition before changing it. 3. Remove 3.x version things since you are only supporting >=40. 4. There is another extension forked from this extension. You should also read these reviews and fix it here: - https://extensions.gnome.org/review/32270 - https://extensions.gnome.org/review/32282 If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
michele_g posted a review
Hi Javad, thanks for the prompt review. Would you be so kind to give some hints about the underlying problems those changes you are suggesting are supposed to prevent? I'm trying to understand whether these are sources of crash/instability (I suspect those timeouts are of this kind?) or if they are just best practices/improvements (e.g. get rid of outdated code) which does not appear to be a blocking issue in my opinion. Thanks, Michele
JustPerfection posted a review
Hi, - For timeouts in extension.js side: As we explained in [ego review guidelines](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources): > You MUST remove all active main loop sources in disable(), even if the callback function will eventually return false or GLib.SOURCE_REMOVE. If you don't remove those timeouts in destroy the callback can get triggered after the disable. Because timeouts can get delayed. That may cause security issue since they can get triggered in lock screen or the destroyed object can get accessed. - For timeouts in prefs.js: Timeouts can get triggered after the prefs window is getting closed. In 42 you can easily access the [window](https://gjs.guide/extensions/upgrading/gnome-shell-42.html#fillpreferenceswindow). so if you insist to include those timeouts in prefs.js, you should remove them in `close-request` of the window. that's being said, you can still get the [window in 40 and 41](https://gjs.guide/extensions/upgrading/gnome-shell-40.html#get-prefs-window-and-resize-it).