Review "Dash to Dock" version 88 - GNOME Shell Extensions

Review of "Dash to Dock" version 88

Details Page Preview

Dash to Dock

A dock for the Gnome Shell. This extension moves the dash out of the overview transforming it in a dock for an easier launching of applications and a faster switching between windows and desktops. Side and bottom placement options are available.

Extension Homepage: https://micheleg.github.io/dash-to-dock/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
99	Active
98	Active
97	Active
96	Active
95	Active
94	Active
93	Active
92	Active
91	Active
90	Rejected
89	Active
88	Rejected
87	Active
86	Rejected
85	Rejected
84	Active
83	Active
82	Active
81	Active
80	Active
79	Active
78	Active
77	Active
76	Rejected
75	Active
74	Active
73	Active
72	Rejected
71	Active
70	Active
69	Active
68	Active
67	Active
66	Active
65	Active
64	Active
63	Active
62	Active
61	Active
60	Active
59	Active
58	Rejected
57	Active
56	Active
55	Active
54	Active
53	Active
52	Active
51	Active
50	Active
49	Active
48	Active
47	Active
46	Active
45	Active
44	Active
43	Active
42	Active
41	Active
40	Active
39	Active
38	Active
37	Active
36	Active
35	Active
34	Active
33	Active
32	Rejected
31	Rejected
30	Active
29	Active
28	Active
27	Active
26	Rejected
25	Active
24	Active
23	Active
22	Active
21	Active
20	Active
19	Active
18	Active
17	Active
16	Active
15	Inactive
14	Active
13	Active
12	Active
11	Active
10	Active
9	Active
8	Rejected
7	Active
6	Active
5	Rejected
4	Active
3	Active
2	Rejected
1	Active

Previous Reviews on this Version

JustPerfection rejected October 9, 2023

We recently added a rule for 45: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gtk-and-gdk-imports 1. You can use `St.IconTheme` instead of line 501 (utils.js): https://gjs-docs.gnome.org/st13~13-icontheme/ 2. Indirect gtk and gdk import (line 5 and 8 dependencies/gi.js) 3. Extensions cannot use `run_dispose()` (line 2652 docking.js): > This function should only be called from object system implementations. https://gjs-docs.gnome.org/gobject20~2.0/gobject.object#method-run_dispose

michele_g posted a review October 9, 2023

Thanks for the review, indeed we've still have lots of leftovers from pre-45 code, that we should eventually address, but for nowI've addressed the main comments at https://github.com/micheleg/dash-to-dock/pull/2101 Cheers Marco.