GNOME Shell Extensions

Review of "Lunar Calendar 农历" version 31

Details Page Preview

Lunar Calendar 农历

by Nei

Display Chinese Lunar Calendar in panel ⚠⚠⚠ dependency: ChineseCalendar by ytliu0: https://gitlab.gnome.org/Nei/ChineseCalendar/-/archive/20240107/ChineseCalendar-20240107.tar.gz

Extension Homepage
https://gitlab.gnome.org/Nei/gnome-shell-extension-lunar-calendar/-/issues
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
49 Active
48 Active
47 Active
46 Active
45 Rejected
44 Active
43 Active
42 Active
41 Active
40 Rejected
39 Rejected
38 Active
37 Rejected
36 Active
35 Active
34 Rejected
33 Active
32 Active
31 Rejected
30 Active
29 Active
28 Active
27 Active
26 Active
25 Active
24 Rejected
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Rejected
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

Nei auto- active
JustPerfection rejected
1. Use `ExtensionUtils.getSettings()` instead of creating your own custom function (remove convenience.js after that): https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/extensionUtils.js 2. Lang is a deprecated module. Please remove it for the next version: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice Learn how to remove Lang from your code: https://gjs.guide/guides/gjs/legacy-class-syntax.html 3. Please add GitHub or GitLab url to the metadata.json: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed 4. `settings` shouldn't be global. make it local and you can attach it to the prefs widget to avoid garbage collection before closing the prefs window (line 19 prefs.js). If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
Nei posted a review
do you really need to force-disable a working extension? I can try to address these points later but the extension should remain working in older versions as well
JustPerfection posted a review
I rejected this one since the old review hasn't been addressed in newer versions: https://extensions.gnome.org/review/27009 Plus, #4 cannot pass the review as stated in review guidelines (global var is the same as init): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization We don't want extensions in 44 have that issue.