Review of "GJS OSK" version 1

Details Page Preview

A new Onscreen Keyboard built using GNOME JS

Extension Homepage
https://github.com/Vishram1123/gjs-osk

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

Vishram1123 posted a review
JustPerfection rejected
1. Move lines 15-16 (prefs.js) to `fillPreferencesWindow()`: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 2. Do not import Gdk and Gtk in extension.js (line 9 and 10). Importing Gtk in extension.js isn't allowed until you don't have any other options. Use spawn command to open url: `xdg-open URL`. 3. Remove Lang, Atspi and Meta imports (extension.js). 4. Please remove unnecessary logs (line 79 and 882 extension.js). 6. Also null out `this.settings` in disable. 7. Don't name a function `spawnCommandLine` when it's not clearly doing that (line 686 extension.js). 8. Remove the timeouts on destroy or disable (line 298, 325, 691 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources If you need any help with your extension you can ask us on: - [GNOME Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions