Review of "GJS OSK" version 7

Details Page Preview

A new Onscreen Keyboard built using GNOME JS

Extension Homepage
https://github.com/Vishram1123/gjs-osk

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

corvettecole rejected
Newer version submitted
Vishram1123 waiting for author
@corettecole this is for GNOME 45, whereas the "newer" version is for gnome 44 and below. If this isn't how I am supposed to submit it, then how do I package the extension for both gnome 44 and below, and gnome 45 and up at the same time?
Vishram1123 posted a review
JustPerfection rejected
This version has the same issue as version 8. Please read the version 8 review for that. also, 1. No need for using the parameter for `this.getSettings()` (line 114 extension.js). 2. Use `get_child()` instead of line 115 (extension.js): https://gjs-docs.gnome.org/gio20~2.0/gio.settings#method-get_child 3. Get the settings instance you already created in `Extension` as constructor parameter (line 30 extension.js).