Review of "GJS OSK" version 8

Details Page Preview

A new Onscreen Keyboard built using GNOME JS

Extension Homepage
https://github.com/Vishram1123/gjs-osk

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

Vishram1123 posted a review
This is for GNOME 44 and below, whereas version 7 is for gnome 45 and up. If this isn't how I am supposed to submit it, then how do I package the extension for both gnome 44 and below, and gnome 45 and up at the same time?
JustPerfection rejected
It's ok, multi versioning is supported here but: 1. You shouldn't check for those integer values (line 268-287 extension.js). Just check whether that is not null. 2. Interval should be removed on `destroy()` (line 232 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 3. You should disconnect with signal id (line 166, 173, 212 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals 4. Also null out these in disable: ```js this.settings = null; this.Keyboard = null; ```