Review "GJS OSK" version 24 - GNOME Shell Extensions

Review of "GJS OSK" version 24

Details Page Preview

GJS OSK

by Vishram1123

A new Onscreen Keyboard built using GNOME JS

Extension Homepage: https://github.com/Vishram1123/gjs-osk

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
32	Active
31	Active
30	Rejected
29	Inactive
28	Inactive
27	Inactive
26	Inactive
25	Inactive
24	Rejected
23	Rejected
22	Rejected
21	Rejected
20	Inactive
19	Inactive
18	Inactive
17	Inactive
16	Inactive
15	Inactive
14	Rejected
13	Rejected
12	Rejected
11	Rejected
10	Inactive
9	Rejected
8	Rejected
7	Rejected
6	Rejected
5	Rejected
4	Inactive
3	Rejected
2	Rejected
1	Rejected

Previous Reviews on this Version

JustPerfection rejected July 15, 2024

1. Please null out on disable: ```js this.darkSchemeSettings = null; this.inputLanguageSettings = null; this.gnomeKeyboardSettings = null; ``` [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 2. Please remove `session-modes` or follow the rules: [EGO Review Guidelines: Metadata Session Modes](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed)