Review of "GJS OSK" version 9

Details Page Preview

A new Onscreen Keyboard built using GNOME JS

Extension Homepage
https://github.com/Vishram1123/gjs-osk

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

Vishram1123 posted a review
JustPerfection rejected
1. Please remove `.pot` file: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 2. Also null out in disable: ```js keycodes = null; ``` 3. Both blocks doing the same. No need to check. Just simply remove the timeout (line 188 `extension.js`). 4. You should remove the previous timeout in case they exist (line 92 `extension.js`). 5. Unused import (line 4 `prefs.js`). 6. Timeout should be removed on destroy (line 931, 928 and 972 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 7. Don't use the same property name for the timeout id you are storing (line 931 and 972 `extension.js`).
Vishram1123 posted a review
I don't know what you mean by comment 3, but I fixed everything else in the latest revision
Vishram1123 posted a review
Or at least I should have