Review of "GJS OSK" version 11

Details Page Preview

A new Onscreen Keyboard built using GNOME JS

Extension Homepage
https://github.com/Vishram1123/gjs-osk

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection waiting for author
Is there any way to make the key codes a dependency without including `keycodes.tar.xz` in the package? Like npm, ... Unpacking that file on each enable is too much.
Vishram1123 posted a review
"keycodes.tar.gz" is generated using a Python program that utilizes `xkbcommon`, a library that isn't available through GJS or NPM (as far as I know, if it is possible, please let me know and I will implement a GJS equivalent of this Python script). Additionally, using a plain text file or a folder results in the final extension archive being too large for usage. I tried to call the Python script through GLib.spawn_command_line_sync, but it seemed too painful for the end user to have to install all of the dependencies. Please suggest any alternatives if possible. (Python script which generates a single keymap: https://github.com/Vishram1123/gjs-osk/blob/main/genKeyMap.py) (Shell script which generates a folder of all keymaps: https://github.com/Vishram1123/gjs-osk/blob/main/genAllKeyMaps.sh)
JustPerfection rejected
Ok but I'm going to reject this one since you are extracting on each enable without checking whether it is unpacked before (line 145 `extension.js`). btw, as we [recommended on EGO review guidelines](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#scripts-and-binaries), you can mention `pip` command in the description for the dependencies.