Review of "system-monitor-next" version 57

Details Page Preview

Display system information in GNOME Shell status bar, such as memory, CPU, disk and battery usages, network rates… Please see the extension homepage for prerequisite packages that must be installed first. If you get an error after updating, try restarting GNOME Shell or logging out and logging back in.

Extension Homepage
https://github.com/mgalgs/gnome-shell-system-monitor-next-applet

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Don't use `var`. Use `let` and `const` instead. 2. Extensions cannot use `run_dispose()` (line 2544 extension.js): > This function should only be called from object system implementations. https://gjs-docs.gnome.org/gobject20~2.0/gobject.object#method-run_dispose 3. Timeout should be removed on destroy (line 2381, 2483 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 4. You cannot have the same property name (`this.timeout`) for the timeout id (line 918, 930 and 944 extension.js). To solve that, create a method that creates `timeout_add...` once an remove `this.timeout` before creating new one. The same issue is happening for `this.in_to` and `this.out_to` (extension.js).