Review of "system-monitor-next" version 74

Details Page Preview

Display system information in GNOME Shell status bar, such as memory, CPU, disk and battery usages, network rates… If you get an error after updating, try logging out and logging back in (this is a known issue that is being worked on).

Extension Homepage
https://github.com/mgalgs/gnome-shell-system-monitor-applet

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
Please only use `schemas/org.gnome.shell.extensions.system-monitor-next-applet.gschema.xml` for the correct xml filename: [EGO Review Guidelines: GSettings Schemas](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#gsettings-schemas) And please remove v0 file since GNOME Shell automatically generates the compiled file for shcemas.
mgalgs posted a review
Ok, I've fixed the XML filenames as per the EGO Review Guidelines. The reason we have two schema definition files is because we're migrating the schema ID to something more unique for this extension. The current schema ID clashes with an official Gnome extension as well as the upstream version of this extension (this is a fork). There's bit more background on this migration process here [1], but the summary is that we want to rename the schema ID without existing users losing their settings, so we're shipping both schemas, and during extension startup we copy settings from the old schema to the new one. After a few months or so we'll remove the old one. [1] https://discourse.gnome.org/t/settings-migration-after-a-schema-rename/25047