Review of "Tiling Shell" version 17.2 (65)

Details Page Preview

Extend Gnome Shell with advanced tiling window management. Supports multiple monitors, Windows 11 Snap Assistant, Fancy Zones, automatic tiling, keyboard shortcuts, customised tiling layouts and more!

Extension Homepage
https://github.com/domferr/tilingshell

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
17.2 (65) Rejected
17.2 (64) Rejected
17.2 (63) Rejected
17.1 (62) Active
17.1 (61) Active
17.1 (60) Rejected
17.0 (59) Active
17.0 (58) Active
17.0 (57) Inactive
17.0 (56) Rejected
16.4 (55) Active
16.4 (54) Active
16.4 (53) Rejected
16.3 (52) Inactive
16.3 (51) Active
16.2 (50) Active
16.2 (49) Active
16.1 (48) Active
16.1 (47) Active
16.0 (46) Inactive
16.0 (45) Inactive
16.0 (44) Inactive
15.1 (43) Active
15.1 (42) Active
15.1 (41) Rejected
15.0 (40) Active
15.0 (39) Active
15.0 (38) Rejected
14.1 (37) Active
14.1 (36) Active
14.1 (35) Rejected
14 (34) Active
14 (33) Active
14 (32) Inactive
14 (31) Rejected
13.1 (30) Active
13.1 (29) Active
13.0 (28) Active
13.0 (27) Active
12.2 (26) Active
12.2 (25) Active
12.1 (24) Active
12.1 (23) Active
12 (22) Active
12 (21) Active
12 (20) Inactive
12 (19) Inactive
11.1 (18) Active
11.1 (17) Active
11 (16) Active
11 (15) Active
11 (14) Rejected
10.0 (13) Active
10.0 (12) Active
9.1 (11) Active
9.1 (10) Active
9.0 (9) Active
9.0 (8) Active
8.0 (7) Active
8.0 (6) Active
5 Active
4 Active
3 Rejected
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
I guess something haven't been configured properly for the final transpiled package since other than functions, every empty new line is removed. Wanna fix and send it again?
domferr posted a review
Thanks for reviewing! My typescript files contain newlines, however after transpiling, every new line is being removed. I am doing a pass on the .js files with eslint and prettier, which are adding a good amount of newlines, but no more than this unfortunately. Not sure if it is improvable, I am using the eslint configuration used by gnome-shell itself. I understand it is not perfect but I hope it is better than bundling everything in extension.js like before
JustPerfection posted a review
Ok. I can review it without those empty new lines but afaics, there are some issues with the final transpiled package here. For example, `ambient.d.js` is included by mistake, or the standalone app doesn't start with `#!@GJS@ -m`, or line 8 `dbus.js` is using `gi.ext.Gio` and also `var` from the next line appeared there.
JustPerfection rejected
1. Please remove `ambient.d.js`. 2. `var` jumped into the end of the previous line: - line 8 `dbus.js` - line 3 `touchPointer.js` - line 33, 51 `tilingManager.js` - line 3 `components/layout/Tile.js` - line 5 `settings/settingsOverride.js` 3. Is there any reason for `monitorDescription.js` needs to be a separate app? Also, standalone gjs script files should start with `#!@GJS@ -m`.